Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535426

[PATCH 1/1] staging: iio: cdc: fix improper return value

Show all headers | View raw

From: Pan Bian <bianpan2016@163.com>

At the end of function ad7150_write_event_config(), directly returns 0.
As a result, the errors will be ignored by the callers. It may be better 
to return variable "ret".

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 drivers/staging/iio/cdc/ad7150.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
index 5578a07..50a5b0c2 100644
--- a/drivers/staging/iio/cdc/ad7150.c
+++ b/drivers/staging/iio/cdc/ad7150.c
@@ -274,7 +274,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
 error_ret:
 	mutex_unlock(&chip->state_lock);
 
-	return 0;
+	return ret;
 }
 
 static int ad7150_read_event_value(struct iio_dev *indio_dev,
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] staging: iio: cdc: fix improper return value Pan Bian <bianpan201602@163.com> - 2016-12-03 15:50 +0100
  Re: [PATCH 1/1] staging: iio: cdc: fix improper return value Jonathan Cameron <jic23@kernel.org> - 2016-12-04 12:00 +0100

csiph-web