Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535382
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Pan Bian <bianpan2016@163.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/1] btrfs: volumes: fix improper return value |
| Date | Sat, 03 Dec 2016 12:40:01 +0100 |
| Message-ID | <sKgPD-wb-9@gated-at.bofh.it> (permalink) |
| X-Original-To | Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>, David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org |
| X-Greylist | delayed 909 seconds by postgrey-1.27 at vger.kernel.org; Sat, 03 Dec 2016 06:38:22 EST |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=/TuU6XgJ0xuWFrylJR eZnc5Redbtb2pSEl9uxVlG0M0=; b=C6J552ikXY3AOoQ58xkX5xPrpR+AtHPMs+ XxRUhvtWuXU18KeCt24LrlQxDw+aDneDPmEYPUYMTJgvN8aikhe1u+zkJCtNhpvf /ReXd8Bi+p1svK67AlgGuXMVlYqKnEMTis1V6wwkBnhTwl/OLWR1iLIwn9Ly/uLM mm0BSTsww= |
| X-Mailer | git-send-email 1.9.1 |
| X-Cm-Transid | C9GowAC3HggZpkJYNBgiIQ--.55077S3 |
| X-Coremail-Antispam | 1Uf129KBjvdXoWrKF1rXFWDZw1kJw48Jw4xJFb_yoWxZrc_Wa 4xXa9Fgr9rJr17Ww1FyFZ8tFZagw1jkr1kJa4aga13tFs8C3Z8Aa1kXrZI9r9rWw4xGr98 Cr9Yqa4jk343GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUedWrJUUUUU== |
| X-Originating-IP | [222.131.246.88] |
| X-Cm-Senderinfo | held01tdqsiiqw6rljoofrz/xtbBZAk1clQG62RUZQAAsG |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 25 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, Pan Bian <bianpan2016@163.com> |
| X-Original-Date | Sat, 3 Dec 2016 19:01:45 +0800 |
| X-Original-Message-ID | <1480762905-5163-1-git-send-email-bianpan2016@163.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1535382 |
Show key headers only | View raw
Variable ret takes the errno on failures. However, it directly returns 0. It may be better to return "ret". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188741 Signed-off-by: Pan Bian <bianpan2016@163.com> --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 71a60cc..32fd903 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -4222,7 +4222,7 @@ static int btrfs_uuid_scan_kthread(void *data) else set_bit(BTRFS_FS_UPDATE_UUID_TREE_GEN, &fs_info->flags); up(&fs_info->uuid_tree_rescan_sem); - return 0; + return ret; } /* -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 1/1] btrfs: volumes: fix improper return value Pan Bian <bianpan2016@163.com> - 2016-12-03 12:40 +0100 Re: [PATCH 1/1] btrfs: volumes: fix improper return value Omar Sandoval <osandov@osandov.com> - 2016-12-03 19:40 +0100
csiph-web