[PATCH 1/1] net: bridge: set error code on failure

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Pan Bian <bianpan2016@163.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] net: bridge: set error code on failure
Date	Sat, 03 Dec 2016 12:40:01 +0100
Message-ID	<sKgPD-wb-13@gated-at.bofh.it> (permalink)
X-Original-To	Stephen Hemminger <stephen@networkplumber.org>, "David S. Miller" <davem@davemloft.net>, bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=bl2EksZqTDO6NvV30y koMm9/yVn6Ek8vLwYsCAGbR6o=; b=aie8R4Vmo6LL/Ae4OBtdFRN9gf93d9D4Ql QaYnxxkfxb1h1Z98CAsPonaZIYT8SStBhQWNh/bNf+uj2QAZKAcrEJHgua5/HUwR cnCyi0NEJNCUrOl8sYulzp9BL0FpDCuKGtK0g/tYwHR1mqM2zFOLfK9Fvquqk/HG Vvyi2YFEo=
X-Mailer	git-send-email 1.9.1
X-Cm-Transid	DdGowADH0eCErUJYv_83Iw--.24451S3
X-Coremail-Antispam	1Uf129KBjvdXoWrZr1ktF4rCrW8CF45GryDJrb_yoW3ZFc_Gr 4xJFyrW3yrtr4DKw43Aw4fJF15tw1F9wn7CrWaqFZIqw1DC393uw4IgFn8Ar17W3ySkrWa 9r1DAa45Z34fCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeN_-PUUUUU==
X-Originating-IP	[222.131.246.88]
X-Cm-Senderinfo	held01tdqsiiqw6rljoofrz/1tbiDgI1clXlhmgmxwABs1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Pan Bian <bianpan2016@163.com>
X-Original-Date	Sat, 3 Dec 2016 19:33:23 +0800
X-Original-Message-ID	<1480764803-5577-1-git-send-email-bianpan2016@163.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1535381

Show key headers only | View raw

Function br_sysfs_addbr() does not set error code when the call
kobject_create_and_add() returns a NULL pointer. It may be better to
return "-ENOMEM" when kobject_create_and_add() fails.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781

Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 net/bridge/br_sysfs_br.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
index e120307..f88c4df 100644
--- a/net/bridge/br_sysfs_br.c
+++ b/net/bridge/br_sysfs_br.c
@@ -898,6 +898,7 @@ int br_sysfs_addbr(struct net_device *dev)
 	if (!br->ifobj) {
 		pr_info("%s: can't add kobject (directory) %s/%s\n",
 			__func__, dev->name, SYSFS_BRIDGE_PORT_SUBDIR);
+		err = -ENOMEM;
 		goto out3;
 	}
 	return 0;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: bridge: set error code on failure Pan Bian <bianpan2016@163.com> - 2016-12-03 12:40 +0100
  Re: [PATCH 1/1] net: bridge: set error code on failure Stephen Hemminger <stephen@networkplumber.org> - 2016-12-05 17:40 +0100
  Re: [PATCH 1/1] net: bridge: set error code on failure David Miller <davem@davemloft.net> - 2016-12-05 19:30 +0100

csiph-web