[PATCH] staging: greybus: Fix macro definition

From	Chinmay VS <cvs268@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: greybus: Fix macro definition
Date	2016-12-03 11:20 +0100
Message-ID	<sKfAe-8jb-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: ChinmayVS <cvs268@gmail.com>

Macros with multiple statements should be enclosed in a do - while loop

Signed-off-by: ChinmayVS <cvs268@gmail.com>
---
 drivers/staging/greybus/loopback.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7882306..39f0a25 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev,		\
 static DEVICE_ATTR_RO(name##_avg)
 
 #define gb_loopback_stats_attrs(field)				\
+do {								\
 	gb_loopback_ro_stats_attr(field, min, u);		\
 	gb_loopback_ro_stats_attr(field, max, u);		\
-	gb_loopback_ro_avg_attr(field)
+	gb_loopback_ro_avg_attr(field)				\
+} while (0)
 
 #define gb_loopback_attr(field, type)					\
 static ssize_t field##_show(struct device *dev,				\
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: greybus: Fix macro definition Chinmay VS <cvs268@gmail.com> - 2016-12-03 11:20 +0100
  Re: [PATCH] staging: greybus: Fix macro definition Greg KH <gregkh@linuxfoundation.org> - 2016-12-03 11:30 +0100
    Re: [PATCH] staging: greybus: Fix macro definition Chinmay V S <cvs268@gmail.com> - 2016-12-03 11:50 +0100

csiph-web