Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1535922

Re: [PATCH 1/1] input: usbhid: fix improper check

From Oliver Neukum <oneukum@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] input: usbhid: fix improper check
Date 2016-12-05 10:20 +0100
Message-ID <sKXBh-2G5-57@gated-at.bofh.it> (permalink)
References <sKxnr-2Wt-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, 2016-12-04 at 13:10 +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@163.com>
> 
> Function hid_post_reset() returns 0 on success, or 1 on failures.

It seems like hid_post_reset() is buggy in not returning
a proper error code in the failure case. So your diagnosis
is right, but the fix is at the wrong place.

	Regards
		Oliver

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] input: usbhid: fix improper check Pan Bian <bianpan201603@163.com> - 2016-12-04 06:20 +0100
  Re: [PATCH 1/1] input: usbhid: fix improper check Oliver Neukum <oneukum@suse.com> - 2016-12-05 10:20 +0100

csiph-web