Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero board

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero board
Date	2016-12-05 10:20 +0100
Message-ID	<sKXBg-2G5-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <sGBzk-2Bt-27@gated-at.bofh.it> <sIi9b-3cw-3@gated-at.bofh.it> <sIi9b-3cw-1@gated-at.bofh.it> <sJwa5-26V-5@gated-at.bofh.it> <sJXah-556-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Dec 02, 2016 at 10:22:30PM +0800, Icenowy Zheng wrote:
> 
> 
> 01.12.2016, 17:36, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > On Mon, Nov 28, 2016 at 12:29:07AM +0000, André Przywara wrote:
> >>  > Something more interesting happened.
> >>  >
> >>  > Xunlong made a add-on board for Orange Pi Zero, which exposes the
> >>  > two USB Controllers exported at expansion bus as USB Type-A
> >>  > connectors.
> >>  >
> >>  > Also it exposes a analog A/V jack and a microphone.
> >>  >
> >>  > Should I enable {e,o}hci{2.3} in the device tree?
> >>
> >>  Actually we should do this regardless of this extension board. The USB
> >>  pins are not multiplexed and are exposed on user accessible pins (just
> >>  not soldered, but that's a detail), so I think they qualify for DT
> >>  enablement. And even if a user can't use them, it doesn't hurt to have
> >>  them (since they are not multiplexed).
> >
> > My main concern about this is that we'll leave regulators enabled by
> > default, for a minority of users. And that minority will prevent to do
> > a proper power management when the times come since we'll have to keep
> > that behaviour forever.
> 
> I think these users can add a 'fdt set /xxx/xxx status "disabled" ' .

You can't ask that from the majority of users. These users will take
debian or fedora, install it, and expect everything to work
properly. I would make the opposite argument actually. If someone is
knowledgeable enough to solder the USB pins a connector, then (s)he'll
be able to make that u-boot call.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero  board André Przywara <andre.przywara@arm.com> - 2016-11-28 01:40 +0100
  Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero  board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-12-01 10:50 +0100
    Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero  board Hans de Goede <hdegoede@redhat.com> - 2016-12-02 15:40 +0100
      Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero  board Andre Przywara <andre.przywara@arm.com> - 2016-12-02 17:20 +0100
        Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero board Chen-Yu Tsai <wens@csie.org> - 2016-12-02 17:50 +0100
        Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero  board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-12-05 10:20 +0100
    Re: [PATCH v2 2/3] ARM: dts: sunxi: add support for Orange Pi Zero  board Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-12-05 10:20 +0100

csiph-web