Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535318

Re: [PATCH] clk: uniphier: Fix build with gcc-4.4.

Show all headers | View raw

Hi Vinson,

2016-12-03 9:37 GMT+09:00 Vinson Lee <vlee@freedesktop.org>:
> gcc-4.4 has issues with anonymous unions in initializers.
>
>   CC      drivers/clk/uniphier/clk-uniphier-sys.o
> drivers/clk/uniphier/clk-uniphier-sys.c:45: error: unknown field ‘factor’ specified in initializer
>
> Fixes: 1574d5722636 ("clk: uniphier: remove unneeded member name for union")
> Signed-off-by: Vinson Lee <vlee@freedesktop.org>


This driver has COMPILE_TEST option, but kbuild test robot
did not mention about this.



This is a bad way of fixing, I think.
(what if a new member is inserted before the union in the future?)

Rather, please revert the bad commit.


>                 .name = "sd" #ch "-sel",                                \
>                 .type = UNIPHIER_CLK_TYPE_MUX,                          \
>                 .idx = -1,                                              \
> -               .mux = {                                                \
> +               { .mux = {                                              \
>                         .parent_names = {                               \
>                                 "sd-44m",                               \
>                                 "sd-33m",                               \
> @@ -63,7 +63,7 @@
>                                 0x00001200,                             \
>                                 0x00001300,                             \
>                         },                                              \
> -               },                                                      \
> +               } },                                                    \
>         },                                                              \


No, please do not do this.






-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: uniphier: Fix build with gcc-4.4. Vinson Lee <vlee@freedesktop.org> - 2016-12-03 02:10 +0100
  Re: [PATCH] clk: uniphier: Fix build with gcc-4.4. Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-12-03 02:30 +0100
    Re: [PATCH] clk: uniphier: Fix build with gcc-4.4. Stephen Boyd <sboyd@codeaurora.org> - 2016-12-07 00:20 +0100
      Re: [PATCH] clk: uniphier: Fix build with gcc-4.4. Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-12-07 02:40 +0100
      Re: [PATCH] clk: uniphier: Fix build with gcc-4.4. Arnd Bergmann <arnd@arndb.de> - 2016-12-07 23:50 +0100

csiph-web