Re: [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default

From	Finn Thain <fthain@telegraphics.com.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default
Date	2016-12-03 01:40 +0100
Message-ID	<sK6wW-2ve-15@gated-at.bofh.it> (permalink)
References	<syrns-7fi-11@gated-at.bofh.it> <syrnt-7fi-51@gated-at.bofh.it> <syYt3-3jx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Ondrej,

On Wed, 2 Nov 2016, I wrote:

> 
> I think this patch is incomplete and you should add these changes:
> 
> diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
> index 7299ad9..0bf0322 100644
> --- a/drivers/scsi/g_NCR5380.c
> +++ b/drivers/scsi/g_NCR5380.c
> @@ -44,7 +44,7 @@ static int ncr_53c400;
>  static int ncr_53c400a;
>  static int dtc_3181e;
>  static int hp_c2502;
> -module_param(ncr_irq, int, 0);
> +module_param(ncr_irq, int, IRQ_AUTO);

Oops, this doesn't even compile! Sorry about that.

What I was trying to achieve was,

-static int ncr_irq;
+static int ncr_irq = IRQ_AUTO;

I will update my patch queue, compile test it, and ask you to review.

--

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] g_NCR5380: Autoprobe IRQ by default Finn Thain <fthain@telegraphics.com.au> - 2016-12-03 01:40 +0100

csiph-web