Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix domain socket
Date	2016-12-03 00:20 +0100
Message-ID	<sK5hw-1NF-15@gated-at.bofh.it> (permalink)
References	<sxHuh-2gb-3@gated-at.bofh.it> <sCALv-7kD-3@gated-at.bofh.it> <sK1nA-7Px-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 02 Dec 2016 10:59:56 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:

> On Sat, 2016-11-12 at 10:17 +0300, Stephen Hemminger wrote:
> > On Sat, 29 Oct 2016 22:20:19 +0300
> > Isaac Boukris <iboukris@gmail.com> wrote:
> >   
> > > Abstract unix domain socket may embed null characters,
> > > these should be translated to '@' when printed by ss the
> > > same way the null prefix is currently being translated.
> > > 
> > > Signed-off-by: Isaac Boukris <iboukris@gmail.com>  
> > 
> > Applied  
> 
> Probably not a good idea to have :
> 
>                        for (int i = 0; i < len; i++)
>                                if (name[i] == '\0')
>                                        name[i] = '@';
> 
> ss.c: In function 'unix_show_sock':
> ss.c:3128:4: error: 'for' loop initial declarations are only allowed in C99 mode
> ss.c:3128:4: note: use option -std=c99 or -std=gnu99 to compile your code
> make[1]: *** [ss.o] Error 1
> 
> 
> 

Thanks, fixed by patch from Simon

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix  domain socket Eric Dumazet <eric.dumazet@gmail.com> - 2016-12-02 20:10 +0100
  Re: [PATCH] iproute2: ss: escape all null bytes in abstract unix  domain socket Stephen Hemminger <stephen@networkplumber.org> - 2016-12-03 00:20 +0100

csiph-web