Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize

From	Clemens Ladisch <clemens@ladisch.de>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize
Date	2016-12-01 13:00 +0100
Message-ID	<sJybU-3lh-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <sJ7Y6-3eC-1@gated-at.bofh.it> <sJuhY-PI-25@gated-at.bofh.it> <sJvxo-1QI-43@gated-at.bofh.it> <sJxzb-38x-1@gated-at.bofh.it> <sJxIR-3bK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Takashi Iwai wrote:
> Clemens Ladisch wrote:
>> Takashi Iwai wrote:
>>> [...]
>>> In the commit mentioned above, we changed the logic to take +25%
>>> frequency as the basis, and it my *reduce* if ep->maxpacksize is lower
>>> than that.
>>>
>>> OTOH, if ep->maxpacksize is sane, we can rely on it rather than the
>>> implicit +25% frequency.  That said, maybe we can check
>>> ep->maxpacksize whether it fits within the expected range, then adapt
>>> it, or take +25% freq as fallback?
>>
>> You are describing how the current code behaves.  The +25% limit _is_
>> what the code takes as the expected range.
>
> Well, the question is what is the "sane" range.  +25% doesn't fit for
> some devices.

The USB audio specification _requires_ that there is as little jitter
as possible.

It's no surprise that some device violates the specification.  But
we don't know what the actual error is; whether we could adjust the
packet size for this particular device only, or increase the limit
for all devices, or use a completely different workaround.

> If maxpacksize fits without +100% as this patch suggests, can we rely
> on it instead?

The packet size affect the following computations, like the number of
packets per URB.  I don't know how bad the effects would be.

Regards,
Clemens

Thread

[PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Jiada Wang <jiada_wang@mentor.com> - 2016-11-30 09:00 +0100
  Re: [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Takashi Iwai <tiwai@suse.de> - 2016-11-30 10:00 +0100
    Re: [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Jiada Wang <jiada_wang@mentor.com> - 2016-12-01 08:10 +0100
  Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant  packetsize Clemens Ladisch <clemens@ladisch.de> - 2016-12-01 08:50 +0100
    Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Takashi Iwai <tiwai@suse.de> - 2016-12-01 10:10 +0100
      Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant  packetsize Clemens Ladisch <clemens@ladisch.de> - 2016-12-01 12:20 +0100
        Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Takashi Iwai <tiwai@suse.de> - 2016-12-01 12:30 +0100
          Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant  packetsize Clemens Ladisch <clemens@ladisch.de> - 2016-12-01 13:00 +0100
    Re: [alsa-devel] [PATCH 1/3 v1] ALSA: usb-audio: more tolerant  packetsize Clemens Ladisch <clemens@ladisch.de> - 2016-12-01 13:20 +0100

csiph-web