[PATCH] dmaengine: at_xdmac: don't restore unsaved status

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	[PATCH] dmaengine: at_xdmac: don't restore unsaved status
Date	2016-12-01 11:50 +0100
Message-ID	<sJx6a-2JW-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

save_gs is supposed to save the channel status in order to be restored at
resume time but it is never updated and is always 0. Anyway, the channel
status is updated in the per channel loop later in the resume function.

Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 drivers/dma/at_xdmac.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index b7d7f2d443a1..8c1abb794340 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -221,7 +221,6 @@ struct at_xdmac {
 	int			irq;
 	struct clk		*clk;
 	u32			save_gim;
-	u32			save_gs;
 	struct dma_pool		*at_xdmac_desc_pool;
 	struct at_xdmac_chan	chan[0];
 };
@@ -1896,7 +1895,6 @@ static int atmel_xdmac_resume(struct device *dev)
 	}
 
 	at_xdmac_write(atxdmac, AT_XDMAC_GIE, atxdmac->save_gim);
-	at_xdmac_write(atxdmac, AT_XDMAC_GE, atxdmac->save_gs);
 	list_for_each_entry_safe(chan, _chan, &atxdmac->dma.channels, device_node) {
 		atchan = to_at_xdmac_chan(chan);
 		at_xdmac_chan_write(atchan, AT_XDMAC_CC, atchan->save_cc);
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] dmaengine: at_xdmac: don't restore unsaved status Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-01 11:50 +0100
  Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-12-01 12:30 +0100
  Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-12-01 14:00 +0100

csiph-web