Re: [PATCH net] tipc: check minimum bearer MTU

From	Ying Xue <ying.xue@windriver.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] tipc: check minimum bearer MTU
Date	2016-12-01 11:10 +0100
Message-ID	<sJwts-2sN-23@gated-at.bofh.it> (permalink)
References	<sJ9Qd-4q9-1@gated-at.bofh.it> <sJajf-4SL-17@gated-at.bofh.it> <sJd7r-6CQ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>
>> For UDP bearer, it seems insufficient for us to check MTU size only
>> when UDP bearer is enabled. Meanwhile, we should update MTU size for
>> UDP bearer with Path MTU discovery protocol once MTU size is changed
>> after bearer is enabled.
>
> I should admit I'm not that familiar with tipc. Do you mean updating
> b->mtu in response to PMTU updates of the route used for ub->ubsock?

Yes.

> The way I understand it, it would be certainly useful but it's not
> directly related to the security issue this patch addresses as if there
> are no updates, b->mtu cannot get too low and there is no risk of
> a buffer overflow. In other words, reflecting PMTU updates is something
> that can be IMHO left for later.
>

Agreed.

Regards,
Ying

>                                                       Michal Kubecek
>

Thread

[PATCH net] tipc: check minimum bearer MTU Michal Kubecek <mkubecek@suse.cz> - 2016-11-30 11:00 +0100
  Re: [PATCH net] tipc: check minimum bearer MTU Michal Kubecek <mkubecek@suse.cz> - 2016-11-30 11:30 +0100
    Re: [PATCH net] tipc: check minimum bearer MTU Ben Hutchings <ben@decadent.org.uk> - 2016-12-01 01:10 +0100
  Re: [PATCH net] tipc: check minimum bearer MTU Ying Xue <ying.xue@windriver.com> - 2016-11-30 11:30 +0100
    Re: [PATCH net] tipc: check minimum bearer MTU Michal Kubecek <mkubecek@suse.cz> - 2016-11-30 14:30 +0100
      Re: [PATCH net] tipc: check minimum bearer MTU Ying Xue <ying.xue@windriver.com> - 2016-12-01 11:10 +0100
  Re: [PATCH net] tipc: check minimum bearer MTU kbuild test robot <lkp@intel.com> - 2016-12-01 08:30 +0100

csiph-web