Re: [PATCH] V4l: omap3isp: Clean up file handle in open() and release().

From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] V4l: omap3isp: Clean up file handle in open() and release().
Date	2016-12-01 11:30 +0100
Message-ID	<sJwMN-2D6-5@gated-at.bofh.it> (permalink)
References	<sJrtL-7pP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Shailendra,

Thank you for the patch.

On Thursday 01 Dec 2016 10:15:40 Shailendra Verma wrote:
> Both functions initialize the file handle with v4l2_fh_init()
> and thus need to call clean up with v4l2_fh_exit() as appropriate.
> 
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree for v4.11.

> ---
>  drivers/media/platform/omap3isp/ispvideo.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/platform/omap3isp/ispvideo.c
> b/drivers/media/platform/omap3isp/ispvideo.c index 7354469..9f966e8 100644
> --- a/drivers/media/platform/omap3isp/ispvideo.c
> +++ b/drivers/media/platform/omap3isp/ispvideo.c
> @@ -1350,6 +1350,7 @@ static int isp_video_open(struct file *file)
>  done:
>  	if (ret < 0) {
>  		v4l2_fh_del(&handle->vfh);
> +		v4l2_fh_exit(&handle->vfh);
>  		kfree(handle);
>  	}
> 
> @@ -1373,6 +1374,7 @@ static int isp_video_release(struct file *file)
> 
>  	/* Release the file handle. */
>  	v4l2_fh_del(vfh);
> +	v4l2_fh_exit(vfh);
>  	kfree(handle);
>  	file->private_data = NULL;

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] V4l: omap3isp: Clean up file handle in open() and release(). Shailendra Verma <shailendra.v@samsung.com> - 2016-12-01 05:50 +0100
  Re: [PATCH] V4l: omap3isp: Clean up file handle in open() and release(). Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-12-01 11:30 +0100

csiph-web