Re: [PATCH v2] mtd: maps: add missing iounmap() in error path

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mtd: maps: add missing iounmap() in error path
Date	2016-12-01 03:40 +0100
Message-ID	<sJprX-67d-11@gated-at.bofh.it> (permalink)
References	<sGoVr-2Zf-1@gated-at.bofh.it> <sGPsB-31Y-9@gated-at.bofh.it> <sHpFL-1In-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Nov 25, 2016 at 03:18:09PM +0100, Marek Vasut wrote:
> On 11/24/2016 12:40 AM, Luis Henriques wrote:
> > This patch was triggered by the following Coccinelle error:
> > 
> > ./drivers/mtd/maps/sc520cdp.c:246:3-9: \
> > 	ERROR: missing iounmap; ioremap on line 242 \
> > 	and execution via conditional on line 244
> > 
> > Since do_map_probe() is also invoked in this loop, it is also necessary to
> > map_destroy() any initialised struct mtd_info.
> > 
> > Signed-off-by: Luis Henriques <henrix@camandro.org>
> > ---
> > Changes since v1:
> > * Changes according to Brian Norris review:
> >   - Ensure sc520cdp_map[0].virt is unmaped when needed
> >   - Use a for loop instead of an 'if (i)'
> >   - Prevent double-iounmap
> > * Added map_destroy() in the cleanup
> > 
> > drivers/mtd/maps/sc520cdp.c | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)

...

> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

Applied to l2-mtd.git

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] mtd: maps: add missing iounmap() in error path Marek Vasut <marek.vasut@gmail.com> - 2016-11-25 15:30 +0100
  Re: [PATCH v2] mtd: maps: add missing iounmap() in error path Brian Norris <computersforpeace@gmail.com> - 2016-12-01 03:40 +0100

csiph-web