Re: [RFC][PATCHv4 2/6] printk: rename nmi.c and exported api

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCHv4 2/6] printk: rename nmi.c and exported api
Date	2016-12-01 02:10 +0100
Message-ID	<sJo2S-5lf-33@gated-at.bofh.it> (permalink)
References	<swVfX-3Pm-11@gated-at.bofh.it> <swVfY-3Pm-37@gated-at.bofh.it> <sH5e2-5eA-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (11/24/16 17:35), Petr Mladek wrote:
[..]
> >  #ifdef CONFIG_PRINTK_NMI
> > -extern void printk_nmi_init(void);
> > -extern void printk_nmi_enter(void);
> > -extern void printk_nmi_exit(void);
> > -extern void printk_nmi_flush(void);
> > -extern void printk_nmi_flush_on_panic(void);
> > +extern void printk_safe_init(void);
> > +extern void printk_safe_nmi_enter(void);
> > +extern void printk_safe_nmi_exit(void);
> 
> I would personally keep the short names pritnk_nmi_enter() and
> printk_nmi_exit(). These are the only functions that will stay
> in this CONFIG_PRINT_NMI section. The others are generic and
> will be moved to the generic section in the next patch.

I'd probably prefer all printk_safe functions to be printk_safe
prefixed, just to show the fact that those are printk_safe
functions (IOW, indirect output to a per-CPU buffer and flush
it to logbuf later).

> Well, it is just a cosmetic problem and a personal opinion.
> The patch makes sense and looks fine:
> 
> Reviewed-by: Petr Mladek <pmladek@pmladek@suse.com>

thanks.

	-ss

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCHv4 2/6] printk: rename nmi.c and exported api Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-12-01 02:10 +0100
  Re: [RFC][PATCHv4 2/6] printk: rename nmi.c and exported api Petr Mladek <pmladek@suse.com> - 2016-12-01 13:20 +0100

csiph-web