Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1533694

Re: [PATCH] audit: remove the audit freelist

Show all headers | View raw

On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal <fw@strlen.de> wrote:
> allows better debugging as freeing audit buffers now always honors slub
> debug hooks (e.g. object poisoning) and leak checker can detect the
> free operation.
>
> Removal also results in a small speedup (using
> single rule 'iptables -A INPUT -i lo -j AUDIT --type drop'):
>
> super_netperf 4 -H 127.0.0.1 -l 360 -t UDP_RR -- -R 1 -m 64
> Before:
> 294953
> After:
> 298013
>
> (alloc/free no longer serializes on spinlock, allocator can use percpu
>  pool).
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
>  kernel/audit.c | 53 ++++++++---------------------------------------------
>  1 file changed, 8 insertions(+), 45 deletions(-)

Sorry for the delay, I was hoping to have some time to play around
with this and offer a more meaningful comment ... I've often wondered
about converting audit_buffer, and audit_context for that matter, over
to their own kmem_cache; have you considered that?  Or was this
proposed due to simplicity?

-- 
paul moore
www.paul-moore.com

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] audit: remove the audit freelist Paul Moore <paul@paul-moore.com> - 2016-12-01 01:10 +0100
  Re: [PATCH] audit: remove the audit freelist Florian Westphal <fw@strlen.de> - 2016-12-01 02:50 +0100
    Re: [PATCH] audit: remove the audit freelist Paul Moore <paul@paul-moore.com> - 2016-12-02 01:10 +0100
      Re: [PATCH] audit: remove the audit freelist Florian Westphal <fw@strlen.de> - 2016-12-02 01:20 +0100
        Re: [PATCH] audit: remove the audit freelist Paul Moore <paul@paul-moore.com> - 2016-12-02 23:00 +0100

csiph-web