[PATCH] HID: intel_ish-hid: use %pUL for uuid formatting

From	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Newsgroups	linux.kernel
Subject	[PATCH] HID: intel_ish-hid: use %pUL for uuid formatting
Date	2016-11-30 23:50 +0100
Message-ID	<sJlRo-3GR-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We have the %pU printf extension for doing exactly this. Saves some
.text, and is likely also a little faster.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index 256521509d20..f4cbc744e657 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -585,14 +585,7 @@ int ishtp_bus_new_client(struct ishtp_device *dev)
 	 */
 	i = dev->fw_client_presentation_num - 1;
 	device_uuid = dev->fw_clients[i].props.protocol_name;
-	dev_name = kasprintf(GFP_KERNEL,
-		"{%02X%02X%02X%02X-%02X%02X-%02X%02X-%02X%02X-%02X%02X%02X%02X%02X%02X}",
-		device_uuid.b[3], device_uuid.b[2], device_uuid.b[1],
-		device_uuid.b[0], device_uuid.b[5], device_uuid.b[4],
-		device_uuid.b[7], device_uuid.b[6], device_uuid.b[8],
-		device_uuid.b[9], device_uuid.b[10], device_uuid.b[11],
-		device_uuid.b[12], device_uuid.b[13], device_uuid.b[14],
-		device_uuid.b[15]);
+	dev_name = kasprintf(GFP_KERNEL, "{%pUL}", device_uuid.b);
 	if (!dev_name)
 		return	-ENOMEM;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: intel_ish-hid: use %pUL for uuid formatting Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-11-30 23:50 +0100
  Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-12-01 15:30 +0100
    Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-12-02 01:00 +0100
  Re: [PATCH] HID: intel_ish-hid: use %pUL for uuid formatting Jiri Kosina <jikos@kernel.org> - 2016-12-02 15:10 +0100

csiph-web