Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1533584

Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address

From Gregory CLEMENT <gregory.clement@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address
Date 2016-11-30 22:30 +0100
Message-ID <sJkBX-2U2-1@gated-at.bofh.it> (permalink)
References <sIS2Z-1lb-3@gated-at.bofh.it> <sIS2Z-1lb-3@gated-at.bofh.it> <sIS30-1lb-33@gated-at.bofh.it> <sJigO-1kn-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi David,
 
 On mer., nov. 30 2016, David Miller <davem@davemloft.net> wrote:

> From: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Date: Tue, 29 Nov 2016 15:55:21 +0100
>
>> +	/* Virtual address of the RX buffer */
>> +	void  **buf_virt_addr;
>> +
>>  	/* Virtual address of the RX DMA descriptors array */
>>  	struct mvneta_rx_desc *descs;
>>  
>  ...
>> +		data = (unsigned char *)rxq->buf_virt_addr[index];
>
> This cast is unnecessary, please remove it.

OK I am doing it now.

Thanks,

Gregory


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 net-next 0/7] Support Armada 37xx SoC (ARMv8 64-bits) in mvneta driver Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-29 16:00 +0100
  [PATCH v4 net-next 6/7] net: mvneta: Add network support for Armada 3700 SoC Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-29 16:00 +0100
  [PATCH v4 net-next 5/7] net: mvneta: Only disable mvneta_bm for 64-bits Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-29 16:00 +0100
  [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-29 16:00 +0100
    Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to  store the rx buffer virtual address David Miller <davem@davemloft.net> - 2016-11-30 20:00 +0100
      Re: [PATCH v4 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-30 22:30 +0100
  [PATCH v4 net-next 7/7] ARM64: dts: marvell: Add network support for Armada 3700 Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-29 16:00 +0100
  [PATCH v4 net-next 1/7] net: mvneta: Optimize rx path for small frame Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-11-29 16:00 +0100

csiph-web