Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3
Date	2016-11-30 22:00 +0100
Message-ID	<sJk8V-2ve-9@gated-at.bofh.it> (permalink)
References	<sJiAa-1FU-17@gated-at.bofh.it> <sJiAa-1FU-15@gated-at.bofh.it> <sJj3d-1QN-51@gated-at.bofh.it> <sJjZf-2rP-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Nov 30, 2016 at 09:41:26PM +0100, Jernej Škrabec wrote:
> > > > > The only
> > > > > code left from you is for DE2. HDMI stuff is basically copied from
> > > > > Rockhip
> > > > > driver (including EDID reading), TCON code is now reverted to the same
> > > > > as
> > > > > it is in sunxi_display.c. I think it is worth to take a look at EDID
> > > > > code
> > > > > and compare it.
> > > > 
> > > > So is the TCON of DE 2.0 identical to the original TCON?
> > > > 
> > > > If so, we should reuse sun4i-tcon ...
> > > 
> > > Well, TCON is splitted in two parts (two base addresses), one for HDMI and
> > > one for TV. However, register offsets are same as before, so I guess
> > > driver reusage make sense. I think that there are few additional
> > > registers, but they can be ignored for simplefb.
> > 
> > The TCON1 of the H3 is not usable (no ckock). Analog TV has its own
> > clock and I/O area.
> > 
> 
> True, H3 user manual can be misleading sometimes. But this doesn't change the 
> fact that TCON0 has same register offsets with same meaning.

Then yes, we should definitely share the drivers too. So, in the end,
the only thing that is actually new is the display-engine?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3 Jernej Škrabec <jernej.skrabec@gmail.com> - 2016-11-30 20:20 +0100
  Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb  node for H3 Jean-Francois Moine <moinejf@free.fr> - 2016-11-30 20:50 +0100
    Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node for H3 Jernej Škrabec <jernej.skrabec@gmail.com> - 2016-11-30 21:50 +0100
      Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node  for H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-30 22:00 +0100
        Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: sun8i: add simplefb node  for H3 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-12-01 10:00 +0100

csiph-web