Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume
Date	2016-11-30 21:00 +0100
Message-ID	<sJjcR-1U1-5@gated-at.bofh.it> (permalink)
References	<sIZ4t-60M-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: Tue, 29 Nov 2016 16:27:03 -0600

> netif_set_real_num_tx/rx_queues() are required to be called with rtnl_lock
> taken, otherwise ASSERT_RTNL() warning will be triggered - which happens
> now during System resume from suspend:
> cpsw_resume()
> |- cpsw_ndo_open()
>   |- netif_set_real_num_tx/rx_queues()
>      |- ASSERT_RTNL();
> 
> Hence, fix it by surrounding cpsw_ndo_open() by rtnl_lock/unlock() calls.
> 
> Cc: Dave Gerlach <d-gerlach@ti.com>
> Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> Fixes: commit e05107e6b747 ("net: ethernet: ti: cpsw: add multi queue support")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-29 23:30 +0100
  Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning  during resume Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2016-11-30 01:20 +0100
    Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during  resume Dave Gerlach <d-gerlach@ti.com> - 2016-11-30 17:10 +0100
  Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning  during resume David Miller <davem@davemloft.net> - 2016-11-30 21:00 +0100

csiph-web