Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

From	"Valo, Kalle" <kvalo@qca.qualcomm.com>
Newsgroups	linux.kernel
Subject	Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
Date	2016-11-30 19:50 +0100
Message-ID	<sJi77-1gR-3@gated-at.bofh.it> (permalink)
References	<sDF6p-1al-3@gated-at.bofh.it> <sEdrs-6BG-7@gated-at.bofh.it> <sEWeS-2n0-1@gated-at.bofh.it> <sGkI9-8uI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

"Valo, Kalle" <kvalo@qca.qualcomm.com> writes:

> Bjorn Andersson <bjorn.andersson@linaro.org> writes:
>
>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote:
>>
>>> Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>>> > The correct include file for getting errno constants and ERR_PTR() is
>>> > linux/err.h, rather than linux/errno.h, so fix the include.
>>> > 
>>> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled smem_state")
>>> > Acked-by: Andy Gross <andy.gross@linaro.org>
>>> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> 
>>> For some reason this fails to compile now. Can you take a look, please?
>>> 
>>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36xx.ko] undefined!
>>> make[1]: *** [__modpost] Error 1
>>> make: *** [modules] Error 2
>>> 
>>> 5 patches set to Changes Requested.
>>> 
>>> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()
>>> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client
>>
>> This patch was updated with the necessary depends in Kconfig to catch
>> this exact issue and when I pull in your .config (which has QCOM_SMD=n,
>> QCOM_WCNSS_CTRL=n and WCN36XX=y) I can build this just fine.
>>
>> I've tested the various combinations and it seems to work fine. Do you
>> have any other patches in your tree?
>
> This was with the pending branch of my ath.git tree. There are other
> wireless patches (ath10k etc) but I would guess they don't affect here.
>
>> Any stale objects?
>
> Not sure what you mean with this question, but I didn't run 'make clean'
> if that's what you are asking.
>
>> Would you mind retesting this, before I invest more time in trying to
>> reproduce the issue you're seeing?
>
> Sure, I'll take a look but that might take few days.

I didn't find enough time to look at this in detail. I applied this to
my ath.git pending branch, let's see what the kbuild bot finds.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-11-30 19:50 +0100
  Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-12-01 06:20 +0100
    Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-12-01 11:20 +0100
      Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Andy Gross <andy.gross@linaro.org> - 2016-12-01 15:30 +0100
        Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-12-05 12:50 +0100

csiph-web