Re: Ping: [PATCH] PCI/ASPM: Don't retrain link if ASPM not possible.

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: Ping: [PATCH] PCI/ASPM: Don't retrain link if ASPM not possible.
Date	2016-11-30 19:10 +0100
Message-ID	<sJhup-10J-3@gated-at.bofh.it> (permalink)
References	<sEDlU-6OX-47@gated-at.bofh.it> <sJhup-10J-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi David,

On Wed, Nov 30, 2016 at 09:11:11AM -0800, David Daney wrote:
> On 11/17/2016 02:25 PM, David Daney wrote:
> >From: David Daney <david.daney@cavium.com>
> >
> >Some (defective) PCIe devices are not able to reliably do link
> >retraining.
> >
> >Check to see if ASPM is possible between link partners before
> >configuring common clocking, and doing the resulting link retraining.
> >If ASPM is not possible, there is no reason to risk losing access to a
> >device due to an unnecessary link retraining.
> >
> 
> Hi Bjorn,
> 
> It has been a couple of weeks since I originally sent this, and I
> wanted to know if you have had a chance to look at it.  If possible,
> it would be nice to consider for the approaching merge window.

Yes, definitely.  I haven't had a chance yet, but I hope to.  Right
now my top priority is getting the arm64 ECAM quirks in for v4.10.
Once that's settled I'll come back and pick up some of these fixes.

Bjorn

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: Ping: [PATCH] PCI/ASPM: Don't retrain link if ASPM not possible. Bjorn Helgaas <helgaas@kernel.org> - 2016-11-30 19:10 +0100

csiph-web