Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1533454

Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP

From Santosh Shilimkar <santosh.shilimkar@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP
Date 2016-11-30 18:20 +0100
Message-ID <sJgI2-vm-31@gated-at.bofh.it> (permalink)
References <sJgoG-9j-23@gated-at.bofh.it> <sJgyl-s0-17@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


Hi Anrd,

Can you apply this to your non critical fixes queue ?

On 11/30/2016 9:09 AM, Grygorii Strashko wrote:
> + Santosh Shilimkar <santosh.shilimkar@oracle.com>
>
> On 11/30/2016 10:53 AM, Grygorii Strashko wrote:
>> The irq_set_affinity_hint() will always fail when !SMP and
>> Networking will fail on Keystone 2 devices in this case.
>> Hence, fix by ignoring IRQ affinity settings when !SMP.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

>>  drivers/soc/ti/knav_qmss_queue.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/ti/knav_qmss_queue.c
>> b/drivers/soc/ti/knav_qmss_queue.c
>> index b73e353..eacad57 100644
>> --- a/drivers/soc/ti/knav_qmss_queue.c
>> +++ b/drivers/soc/ti/knav_qmss_queue.c
>> @@ -1228,7 +1228,7 @@ static int knav_setup_queue_range(struct
>> knav_device *kdev,
>>
>>          range->num_irqs++;
>>
>> -        if (oirq.args_count == 3)
>> +        if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
>>              range->irqs[i].cpu_map =
>>                  (oirq.args[2] & 0x0000ff00) >> 8;
>>      }
>>
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] soc: ti: qmss: fix the case when !SMP Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-30 18:00 +0100
  Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-30 18:10 +0100
    Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2016-11-30 18:20 +0100
      Re: [PATCH v2] soc: ti: qmss: fix the case when !SMP Arnd Bergmann <arnd@arndb.de> - 2016-11-30 22:20 +0100

csiph-web