Re: [PATCH v2] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drivers/usb: use READ_ONCE instead of deprecated ACCESS_ONCE
Date	2016-11-30 15:30 +0100
Message-ID	<sJe3v-7fx-11@gated-at.bofh.it> (permalink)
References	<sFjXP-OR-3@gated-at.bofh.it> <sIWgi-4bp-27@gated-at.bofh.it> <sJdAu-6My-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 30, 2016 at 05:50:54AM -0800, Davidlohr Bueso wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant drivers/usb/.
> 
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> drivers/usb/class/cdc-wdm.c     | 2 +-
> drivers/usb/core/devio.c        | 2 +-
> drivers/usb/core/sysfs.c        | 4 ++--
> drivers/usb/gadget/udc/gr_udc.c | 4 ++--
> drivers/usb/host/ohci-hcd.c     | 2 +-
> drivers/usb/host/uhci-hcd.h     | 4 ++--
> 6 files changed, 9 insertions(+), 9 deletions(-)

Same comment on your driver base patch, what changed from v1?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers/usb: use READ_ONCE instead of deprecated  ACCESS_ONCE Greg KH <gregkh@linuxfoundation.org> - 2016-11-29 20:30 +0100
  [PATCH v2] drivers/usb: use READ_ONCE instead of deprecated  ACCESS_ONCE Davidlohr Bueso <dave@stgolabs.net> - 2016-11-30 15:00 +0100
    Re: [PATCH v2] drivers/usb: use READ_ONCE instead of deprecated  ACCESS_ONCE Greg KH <gregkh@linuxfoundation.org> - 2016-11-30 15:30 +0100

csiph-web