Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1533316

[PATCH] usb: host: replace symbolic permission with octal

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

This patch handles warning message for preferring octal
permissions over Symbolic permission for module parameter

Signed-off-by: Amit Kushwaha <kushwaha.a@samsung.com>
---
 drivers/usb/host/xhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 1a4ca02..a953d47 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -40,11 +40,11 @@
 
 /* Some 0.95 hardware can't handle the chain bit on a Link TRB being cleared */
 static int link_quirk;
-module_param(link_quirk, int, S_IRUGO | S_IWUSR);
+module_param(link_quirk, int, 0644);
 MODULE_PARM_DESC(link_quirk, "Don't clear the chain bit on a link TRB");
 
 static unsigned int quirks;
-module_param(quirks, uint, S_IRUGO);
+module_param(quirks, uint, 0444);
 MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");
 
 /* TODO: copied from ehci-hcd.c - can this be refactored? */
-- 
2.10.2.windows.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] usb: host: replace symbolic permission with octal Amit Kumar Kushwaha <kushwaha.a@samsung.com> - 2016-11-30 15:00 +0100

csiph-web