Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1535083
| From | Oliver Hartkopp <socketcan@hartkopp.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath |
| Date | 2016-12-02 18:10 +0100 |
| Message-ID | <sJZvs-6Fu-13@gated-at.bofh.it> (permalink) |
| References | <sJVrQ-3Uw-13@gated-at.bofh.it> <sJW4x-4mD-3@gated-at.bofh.it> <sJXN0-5xy-29@gated-at.bofh.it> <sJYzn-64D-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/02/2016 04:42 PM, Marc Kleine-Budde wrote:
> On 12/02/2016 04:11 PM, Oliver Hartkopp wrote:
>>
>>
>> On 12/02/2016 02:24 PM, Marc Kleine-Budde wrote:
>>> On 12/02/2016 01:43 PM, Andrey Konovalov wrote:
>>
>>
>>>> [<ffffffff8369e0de>] raw_setsockopt+0x1be/0x9f0 net/can/raw.c:506
>>>
>>> We should add a check for a sensible optlen....
>>>
>>>> static int raw_setsockopt(struct socket *sock, int level, int optname,
>>>> char __user *optval, unsigned int optlen)
>>>> {
>>>> struct sock *sk = sock->sk;
>>>> struct raw_sock *ro = raw_sk(sk);
>>>> struct can_filter *filter = NULL; /* dyn. alloc'ed filters */
>>>> struct can_filter sfilter; /* single filter */
>>>> struct net_device *dev = NULL;
>>>> can_err_mask_t err_mask = 0;
>>>> int count = 0;
>>>> int err = 0;
>>>>
>>>> if (level != SOL_CAN_RAW)
>>>> return -EINVAL;
>>>>
>>>> switch (optname) {
>>>>
>>>> case CAN_RAW_FILTER:
>>>> if (optlen % sizeof(struct can_filter) != 0)
>>>> return -EINVAL;
>>>
>>> here...
>>>
>>> if (optlen > 64 * sizeof(struct can_filter))
>>> return -EINVAL;
>>>
>>
>> Agreed.
>>
>> But what is sensible here?
>> 64 filters is way to small IMO.
>>
>> When thinking about picking a bunch of single CAN IDs I would tend to
>> something like 512 filters.
>
> Ok - 64 was just an arbitrary chosen value for demonstration purposes :)
>
:-)
Would you like to send a patch?
Regards,
Oliver
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
net/can: warning in raw_setsockopt/__alloc_pages_slowpath Andrey Konovalov <andreyknvl@google.com> - 2016-12-02 13:50 +0100
Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath Marc Kleine-Budde <mkl@pengutronix.de> - 2016-12-02 14:30 +0100
Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath Oliver Hartkopp <socketcan@hartkopp.net> - 2016-12-02 16:20 +0100
Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath Marc Kleine-Budde <mkl@pengutronix.de> - 2016-12-02 17:10 +0100
Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath Oliver Hartkopp <socketcan@hartkopp.net> - 2016-12-02 18:10 +0100
Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath Marc Kleine-Budde <mkl@pengutronix.de> - 2016-12-05 12:00 +0100
csiph-web