Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1535090

Re: [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue lock in tx completion handler

Show all headers | View raw

From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: Wed, 30 Nov 2016 23:48:32 +0100

> The driver already uses its private lock for synchronization between xmit
> and xmit completion handler making the additional use of the xmit_lock
> unnecessary.
> Furthermore the driver does not set NETIF_F_LLTX resulting in xmit to be
> called with the xmit_lock held and then taking the private lock while xmit
> completion handler does the reverse, first take the private lock, then the
> xmit_lock.
> Fix these issues by not taking the xmit_lock in the tx completion handler.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>

Yeah that could be a nasty deadlock, in fact.

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] net: ethernet: altera: TSE: Remove unneeded dma sync for tx buffers Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-30 23:50 +0100
  [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue lock in tx completion handler Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-11-30 23:50 +0100
    Re: [PATCH 2/2] net: ethernet: altera: TSE: do not use tx queue  lock in tx completion handler David Miller <davem@davemloft.net> - 2016-12-02 18:20 +0100
  Re: [PATCH 1/2] net: ethernet: altera: TSE: Remove unneeded dma  sync for tx buffers David Miller <davem@davemloft.net> - 2016-12-02 18:20 +0100

csiph-web