Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1534993
| From | Jesper Nilsson <jesper.nilsson@axis.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: phy: dp83848: Support ethernet pause frames |
| Date | 2016-12-02 16:00 +0100 |
| Message-ID | <sJXtD-5bN-7@gated-at.bofh.it> (permalink) |
| References | <sJX0B-4ZC-9@gated-at.bofh.it> <sJXah-556-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Dec 02, 2016 at 08:35:23AM -0600, Andrew F. Davis wrote:
> On 12/02/2016 08:22 AM, Jesper Nilsson wrote:
> > According to the documentation, the PHYs supported by this driver
> > can also support pause frames. Announce this to be so.
> > Tested with a TI83822I.
> >
>
> Looks like all PHYs supported by this driver do, so:
>
> Acked-by: Andrew F. Davis <afd@ti.com>
>
> > Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
> > ---
> > drivers/net/phy/dp83848.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
> > index 800b39f..6e4117f 100644
> > --- a/drivers/net/phy/dp83848.c
> > +++ b/drivers/net/phy/dp83848.c
> > @@ -88,7 +88,8 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl);
> > .phy_id = _id, \
> > .phy_id_mask = 0xfffffff0, \
> > .name = _name, \
> > - .features = PHY_BASIC_FEATURES, \
> > + .features = (PHY_BASIC_FEATURES | \
> > + SUPPORTED_Pause | SUPPORTED_Asym_Pause),\
>
> Aligning these may look nicer though.
Agreed, will send a v2.
> > .flags = PHY_HAS_INTERRUPT, \
> > \
> > .soft_reset = genphy_soft_reset, \
> >
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: phy: dp83848: Support ethernet pause frames Jesper Nilsson <jesper.nilsson@axis.com> - 2016-12-02 15:30 +0100
Re: [PATCH] net: phy: dp83848: Support ethernet pause frames "Andrew F. Davis" <afd@ti.com> - 2016-12-02 15:40 +0100
Re: [PATCH] net: phy: dp83848: Support ethernet pause frames Jesper Nilsson <jesper.nilsson@axis.com> - 2016-12-02 16:00 +0100
[PATCH v2] net: phy: dp83848: Support ethernet pause frames Jesper Nilsson <jesper.nilsson@axis.com> - 2016-12-02 16:00 +0100
Re: [PATCH v2] net: phy: dp83848: Support ethernet pause frames David Miller <davem@davemloft.net> - 2016-12-05 19:20 +0100
csiph-web