Re: [PATCH RESEND 2/2] gpio: axp209: add pinctrl support

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 2/2] gpio: axp209: add pinctrl support
Date	Fri, 02 Dec 2016 13:40:02 +0100
Message-ID	<sJVia-3Rc-9@gated-at.bofh.it> (permalink)
References	<sGGyZ-5Zq-5@gated-at.bofh.it> <sGGyZ-5Zq-3@gated-at.bofh.it> <sH32x-3T3-1@gated-at.bofh.it> <sIYUN-5Xz-5@gated-at.bofh.it>
X-Original-To	Quentin Schulz <quentin.schulz@free-electrons.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U5blq1G961dvzoZ7kqdjWsczvymxnEv11DCtviZnoMg=; b=fz+XIRw8hYrToabrK/xj/RBh2m9/MuY7IdtVab76PMDBSl1es9M/y1w8nE0t8Nubg/ wRgZT8RLCK4AwKVxd3vGowMBhxPLAtFfcoIGZOcjdGy1937aqPmhEMhJFD28zGi0svhO BjyFwDCbvVpbGAKTlGaxq7xuWpP93ntK0LUDU=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U5blq1G961dvzoZ7kqdjWsczvymxnEv11DCtviZnoMg=; b=N8IpMroQZbI3koIIVQm7j6Da15eAgFgKGWHhF/vESysURM6etshwrXZ6QMdUGpWOMg ZnMkYoRizE+6sTjRWrnXr/QGpjPzUV1T5UAhCCE86ueJ8+E8VOUj+SBRoHIxuP+f6qGA Tg3GGKgP+IenYgNw55d3XNEYHwJXRtXYNCkAgBruFeCWE+2ZVnXzes69yWPlzg35+UUY bp8hIM0+uzWMJ5E2DKpIaRmAL/IjIZqC59w+V1l20kku9544jZU+47He1Zd5X58RwkoR IrXRipXsBwaX2s9UXDmgZ5CWvfC+tXT4SZVDeVtDNprss/EP8jdVSFe+k8dq/JmphTQA 2izQ==
X-Gm-Message-State	AKaTC01I8zIFEbPzQKNlqHzRZHKuw/eQhcVqjG6mT+ZV4SZ6KELjkEjLolG8cBtICIyAQmuqMYWwoSd7O/s+Fo6N
X-Received	by 10.237.33.156 with SMTP id l28mr42593351qtc.111.1480681822905; Fri, 02 Dec 2016 04:30:22 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	23
Organization	linux.* mail to news gateway
X-Original-Cc	Alexandre Courbot <gnurou@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Fri, 2 Dec 2016 13:30:22 +0100
X-Original-Message-ID	<CACRpkdbfeZ1PqtKMpP-6ty=43L1C7QQEmeM91pmN-YiOXeysTA@mail.gmail.com>
X-Original-References	<20161123141151.25315-1-quentin.schulz@free-electrons.com> <20161123141151.25315-3-quentin.schulz@free-electrons.com> <CACRpkdb8cej=AMs2kO1Vks-WYeae+CtAW2YOCc+Pz3E49mcrDQ@mail.gmail.com> <f46c89f2-478b-93b8-5a66-12d1307d4514@free-electrons.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1534886

Show key headers only | View raw

On Tue, Nov 29, 2016 at 11:13 PM, Quentin Schulz
<quentin.schulz@free-electrons.com> wrote:

> So basically:
>
>  - first patch for adding pinctrl to the existing driver
>  - second patch for moving the driver and binding from gpio to pinctrl
> subsystem
>  - third patch for both removing Kconfig entry and Makefile rule from
> gpio subsystem, and adding a Kconfig entry and a Makefile rule in
> pinctrl subsystem
>
> Is that what you want?

No.

Make the patch moving it to pinctrl first. This will be the same as
the patch augmenting Kcongfig and Makefile or it will not compile.

Then a second patch to add the pinctrl features.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RESEND 2/2] gpio: axp209: add pinctrl support Quentin Schulz <quentin.schulz@free-electrons.com> - 2016-11-29 23:20 +0100
  Re: [PATCH RESEND 2/2] gpio: axp209: add pinctrl support Linus Walleij <linus.walleij@linaro.org> - 2016-12-02 13:40 +0100

csiph-web