Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534827

[tip:locking/core] locking/rtmutex: Use READ_ONCE() in rt_mutex_owner()

Show all headers | View raw

Commit-ID:  1be5d4fa0af34fb7bafa205aeb59f5c7cc7a089d
Gitweb:     http://git.kernel.org/tip/1be5d4fa0af34fb7bafa205aeb59f5c7cc7a089d
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Wed, 30 Nov 2016 21:04:42 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 2 Dec 2016 11:13:26 +0100

locking/rtmutex: Use READ_ONCE() in rt_mutex_owner()

While debugging the rtmutex unlock vs. dequeue race Will suggested to use
READ_ONCE() in rt_mutex_owner() as it might race against the
cmpxchg_release() in unlock_rt_mutex_safe().

Will: "It's a minor thing which will most likely not matter in practice"

Careful search did not unearth an actual problem in todays code, but it's
better to be safe than surprised.

Suggested-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: David Daney <ddaney@caviumnetworks.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20161130210030.431379999@linutronix.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/locking/rtmutex_common.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/locking/rtmutex_common.h b/kernel/locking/rtmutex_common.h
index 4f5f83c..e317e1c 100644
--- a/kernel/locking/rtmutex_common.h
+++ b/kernel/locking/rtmutex_common.h
@@ -75,8 +75,9 @@ task_top_pi_waiter(struct task_struct *p)
 
 static inline struct task_struct *rt_mutex_owner(struct rt_mutex *lock)
 {
-	return (struct task_struct *)
-		((unsigned long)lock->owner & ~RT_MUTEX_OWNER_MASKALL);
+	unsigned long owner = (unsigned long) READ_ONCE(lock->owner);
+
+	return (struct task_struct *) (owner & ~RT_MUTEX_OWNER_MASKALL);
 }
 
 /*

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch 0/4] rtmutex: Plug unlock vs. requeue race Thomas Gleixner <tglx@linutronix.de> - 2016-11-30 22:10 +0100
  [patch 4/4] rtmutex: Explain locking rules for  rt_mutex_proxy_unlock()/init_proxy_locked() Thomas Gleixner <tglx@linutronix.de> - 2016-11-30 22:10 +0100
    [tip:locking/core] locking/rtmutex: Explain locking rules for  rt_mutex_proxy_unlock()/init_proxy_locked() tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-12-02 12:20 +0100
  [patch 2/4] rtmutex: Use READ_ONCE() in rt_mutex_owner() Thomas Gleixner <tglx@linutronix.de> - 2016-11-30 22:10 +0100
    [tip:locking/core] locking/rtmutex: Use READ_ONCE() in  rt_mutex_owner() tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-12-02 11:50 +0100
  Re: [patch 0/4] rtmutex: Plug unlock vs. requeue race Peter Zijlstra <peterz@infradead.org> - 2016-12-01 19:40 +0100

csiph-web