Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1534811
| From | Joao Pinto <Joao.Pinto@synopsys.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH] PCI: designware: add host_init() error handling |
| Date | 2016-12-02 11:40 +0100 |
| Message-ID | <sJTq2-2EV-7@gated-at.bofh.it> (permalink) |
| References | <sJybU-3lh-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Srinivas, Às 11:51 AM de 12/1/2016, Srinivas Kandagatla escreveu: > drivers/pci/host/pci-dra7xx.c | 4 +++- > drivers/pci/host/pci-exynos.c | 4 +++- > drivers/pci/host/pci-imx6.c | 4 +++- > drivers/pci/host/pci-keystone.c | 4 +++- > drivers/pci/host/pci-layerscape.c | 12 ++++++++---- > drivers/pci/host/pcie-armada8k.c | 4 +++- > drivers/pci/host/pcie-designware-plat.c | 4 +++- > drivers/pci/host/pcie-designware.c | 4 +++- > drivers/pci/host/pcie-designware.h | 2 +- > drivers/pci/host/pcie-qcom.c | 6 ++++-- > drivers/pci/host/pcie-spear13xx.c | 4 +++- > 11 files changed, 37 insertions(+), 15 deletions(-) > Thanks for the patch! In my opinion your idea is good but only qcom driver is able to detect failure in the specific host init routine, all others have a 'return 0' even if something not well init. I would recomend that we take this issue a bit further and add the error checking to all specific pci drivers in order to make them as robust as qcom'. Thanks, Joao
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH] PCI: designware: add host_init() error handling Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-12-01 13:00 +0100
Re: [RFC PATCH] PCI: designware: add host_init() error handling Joao Pinto <Joao.Pinto@synopsys.com> - 2016-12-02 11:40 +0100
Re: [RFC PATCH] PCI: designware: add host_init() error handling Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-12-02 13:00 +0100
Re: [RFC PATCH] PCI: designware: add host_init() error handling Joao Pinto <Joao.Pinto@synopsys.com> - 2016-12-05 11:40 +0100
csiph-web