Re: [PATCH 4/6] ubifs: Maintain a parent pointer

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] ubifs: Maintain a parent pointer
Date	2016-12-02 11:40 +0100
Message-ID	<sJTq2-2EV-3@gated-at.bofh.it> (permalink)
References	<sJHId-2WG-11@gated-at.bofh.it> <sJHIe-2WG-39@gated-at.bofh.it> <sJStY-22N-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02.12.2016 10:28, Marcus Folkesson wrote:
> On Thu, Dec 01, 2016 at 11:02:19PM +0100, Richard Weinberger wrote:
>>  
>> +	if (new_dir != old_dir) {
>> +		fst_inode_ui->parent_inum = new_dir->i_ino;
>> +		snd_inode_ui->parent_inum = old_dir->i_ino;
>> +	}
>> +
>>  	if (old_dir != new_dir) {
>>  		if (S_ISDIR(fst_inode->i_mode) && !S_ISDIR(snd_inode->i_mode)) {
>>  			inc_nlink(new_dir);
> 
> Insignificant thing, but use the existing if-statment instead?

Of course.
I moved the line around and oversaw the existing branch. :)

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] UBIFS NFS export support Richard Weinberger <richard@nod.at> - 2016-12-01 23:10 +0100
  [PATCH 2/6] ubifs: Provide a custom llseek for directories Richard Weinberger <richard@nod.at> - 2016-12-01 23:10 +0100
  [PATCH 4/6] ubifs: Maintain a parent pointer Richard Weinberger <richard@nod.at> - 2016-12-01 23:10 +0100
    Re: [PATCH 4/6] ubifs: Maintain a parent pointer Marcus Folkesson <marcus.folkesson@gmail.com> - 2016-12-02 10:40 +0100
      Re: [PATCH 4/6] ubifs: Maintain a parent pointer Richard Weinberger <richard@nod.at> - 2016-12-02 11:40 +0100

csiph-web