Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534791

Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in sync if struct page is corrupted

From Michal Hocko <mhocko@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in sync if struct page is corrupted
Date 2016-12-02 11:20 +0100
Message-ID <sJT6F-2yH-5@gated-at.bofh.it> (permalink)
References <sJJTH-4xc-13@gated-at.bofh.it> <sJJTH-4xc-21@gated-at.bofh.it> <sJNaV-6Bq-3@gated-at.bofh.it> <sJPmq-8jy-7@gated-at.bofh.it> <sJStY-22N-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri 02-12-16 17:30:07, Hillf Danton wrote:
[...]
> > >> @@ -2217,13 +2217,14 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order,
> > >>  		else
> > >>  			list_add_tail(&page->lru, list);
> > >>  		list = &page->lru;
> > >> +		alloced++;
> > >>  		if (is_migrate_cma(get_pcppage_migratetype(page)))
> > >>  			__mod_zone_page_state(zone, NR_FREE_CMA_PAGES,
> > >>  					      -(1 << order));
> > >>  	}
> > >>  	__mod_zone_page_state(zone, NR_FREE_PAGES, -(i << order));
> > >
> > > Now i is a pure index, yes?
> > 
> > No, even if a page fails the check_pcp_refill() check and is not
> > "allocated", it is also no longer a free page, so it's correct to
> > subtract it from NR_FREE_PAGES.
> > 
> Yes, we can allocate free page   next time.

No we cannot. The page is gone from the free list. We have effectively
leaked it.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] High-order per-cpu cache v5 Mel Gorman <mgorman@techsingularity.net> - 2016-12-02 01:30 +0100
  [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in sync if struct page is corrupted Mel Gorman <mgorman@techsingularity.net> - 2016-12-02 01:30 +0100
    Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in sync if struct page is corrupted "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-12-02 05:00 +0100
      Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in  sync if struct page is corrupted Vlastimil Babka <vbabka@suse.cz> - 2016-12-02 07:20 +0100
        Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in sync if struct page is corrupted "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2016-12-02 10:40 +0100
          Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in  sync if struct page is corrupted Michal Hocko <mhocko@kernel.org> - 2016-12-02 11:20 +0100
            Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in  sync if struct page is corrupted Mel Gorman <mgorman@techsingularity.net> - 2016-12-02 12:10 +0100
    Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in  sync if struct page is corrupted Michal Hocko <mhocko@kernel.org> - 2016-12-02 09:20 +0100
      Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in  sync if struct page is corrupted Mel Gorman <mgorman@techsingularity.net> - 2016-12-02 10:50 +0100
        Re: [PATCH 1/2] mm, page_alloc: Keep pcp count and list contents in  sync if struct page is corrupted Michal Hocko <mhocko@kernel.org> - 2016-12-02 11:10 +0100
  [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Mel Gorman <mgorman@techsingularity.net> - 2016-12-02 01:30 +0100
    Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-12-02 07:10 +0100
      Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Michal Hocko <mhocko@kernel.org> - 2016-12-02 09:30 +0100
        Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-12-05 04:10 +0100
      Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Mel Gorman <mgorman@techsingularity.net> - 2016-12-02 10:10 +0100
        Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-12-05 04:10 +0100
          Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Mel Gorman <mgorman@techsingularity.net> - 2016-12-05 11:00 +0100
            Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-12-06 03:50 +0100
              Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Mel Gorman <mgorman@techsingularity.net> - 2016-12-06 15:00 +0100
    Re: [PATCH 2/2] mm: page_alloc: High-order per-cpu page allocator v5 Michal Hocko <mhocko@kernel.org> - 2016-12-02 09:30 +0100

csiph-web