Re: [lkp] [printk.c] ea0639c4d5: BUG:recent_printk_recursion

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [lkp] [printk.c] ea0639c4d5: BUG:recent_printk_recursion
Date	Fri, 02 Dec 2016 11:10:01 +0100
Message-ID	<sJSWZ-2sV-5@gated-at.bofh.it> (permalink)
References	<sISw3-1KH-73@gated-at.bofh.it> <sJKG5-55p-15@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Sebastian Duda <sebastian.duda@fau.de>, linux-kernel@i4.cs.fau.de, Tobias Baumeister <tobias.baumeister@fau.de>, Andrew Morton <akpm@linux-foundation.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Borislav Petkov <bp@suse.de>, Tejun Heo <tj@kernel.org>, Thierry Reding <treding@nvidia.com>, open list <linux-kernel@vger.kernel.org>, lkp@01.org
X-Original-Date	Fri, 2 Dec 2016 11:05:58 +0100
X-Original-Message-ID	<20161202100558.GR21230@pathway.suse.cz>
X-Original-References	<1480432743-8049-1-git-send-email-sebastian.duda@fau.de> <20161201171232.GD31607@yexl-desktop>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1534784

Show key headers only | View raw

On Fri 2016-12-02 01:12:32, kernel test robot wrote:
> 
> FYI, we noticed the following commit:
> 
> commit: ea0639c4d5c700ad63c0ace6a7a17877aac5b4c2 ("printk.c: removed unnecessary code")
> url: https://github.com/0day-ci/linux/commits/Sebastian-Duda/printk-c-removed-unnecessary-code/20161130-225006
> 
> 
> in testcase: trinity
> with following parameters:
> 
> 	runtime: 300s
> 
> test-description: Trinity is a linux system call fuzz tester.
> test-url: http://codemonkey.org.uk/projects/trinity/
> 
> 
> on test machine: qemu-system-i386 -enable-kvm -m 256M
> 
> caused below changes:
> 
> 
> +-------------------------------------------------------+------------+------------+
> |                                                       | ded6e842cf | ea0639c4d5 |
> +-------------------------------------------------------+------------+------------+
> | boot_successes                                        | 19         | 8          |
> | boot_failures                                         | 3          | 49         |

I am not surprised. The patch breaks counting of the space
needed to print the message. It is likely to cause buffer
overflows. I have already nacked it, see
https://lkml.kernel.org/r/20161130102231.GE24060@pathway.suse.cz

Anyway, thanks for testing.

Best Regards,
Petr

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] printk.c: removed unnecessary code Sebastian Duda <sebastian.duda@fau.de> - 2016-11-29 16:30 +0100
  Re: [PATCH] printk.c: removed unnecessary code Michal Hocko <mhocko@kernel.org> - 2016-11-30 10:20 +0100
    Re: [PATCH] printk.c: removed unnecessary code Petr Mladek <pmladek@suse.com> - 2016-11-30 11:30 +0100
  Re: [lkp] [printk.c]  ea0639c4d5: BUG:recent_printk_recursion Petr Mladek <pmladek@suse.com> - 2016-12-02 11:10 +0100

csiph-web