Re: [PATCH] bdisp: Clean up file handle in open() error path.

From	Fabien DESSENNE <fabien.dessenne@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bdisp: Clean up file handle in open() error path.
Date	2016-12-02 09:40 +0100
Message-ID	<sJRxT-1gM-9@gated-at.bofh.it> (permalink)
References	<sJO6Z-7cp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Shailendra,
Thank you for the patch, it's good for me.


On 12/02/2016 05:48 AM, Shailendra Verma wrote:
> The File handle is not yet added in the vdev list.So no need to call
> v4l2_fh_del(&ctx->fh)if it fails to create control.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>

Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com>

> ---
>   drivers/media/platform/sti/bdisp/bdisp-v4l2.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
> index 45f82b5..fbf302f 100644
> --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
> +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
> @@ -632,8 +632,8 @@ static int bdisp_open(struct file *file)
>   
>   error_ctrls:
>   	bdisp_ctrls_delete(ctx);
> -error_fh:
>   	v4l2_fh_del(&ctx->fh);
> +error_fh:
>   	v4l2_fh_exit(&ctx->fh);
>   	bdisp_hw_free_nodes(ctx);
>   mem_ctx:

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] bdisp: Clean up file handle in open() error path. Shailendra Verma <shailendra.v@samsung.com> - 2016-12-02 06:00 +0100
  Re: [PATCH] bdisp: Clean up file handle in open() error path. Fabien DESSENNE <fabien.dessenne@st.com> - 2016-12-02 09:40 +0100

csiph-web