Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534682

RE: [PATCH 02/15] hyperv: Add a function to detect hv_device

Show all headers | View raw

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, December 1, 2016 12:36 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com;
> jasowang@redhat.com; leann.ogasawara@canonical.com; Haiyang Zhang
> <haiyangz@microsoft.com>
> Subject: Re: [PATCH 02/15] hyperv: Add a function to detect hv_device
> 
> On Thu, Dec 01, 2016 at 09:28:39AM -0800, kys@exchange.microsoft.com
> wrote:
> > From: Haiyang Zhang <haiyangz@microsoft.com>
> >
> > Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hv/vmbus_drv.c |    6 ++++++
> >  include/linux/hyperv.h |    2 ++
> >  2 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index 0276d2e..1730ac0 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -692,6 +692,12 @@ struct onmessage_work_context {
> >  	struct hv_message msg;
> >  };
> >
> > +bool device_is_hyperv(struct device *dev)
> > +{
> > +	return dev->release == vmbus_device_release;
> > +}
> > +EXPORT_SYMBOL_GPL(device_is_hyperv);
> 
> Wait, eek, no!  That's NOT how you determine a device type, if you
> really even ever need to do that.
> 
> Why are you needing this?  You should always "just know" what type of
> device a struct device * is, that's what we rely on in the driver model.
> Otherwise things get messy very very quickly.
> 
> Sorry, I can't take this without a ton of justification, and even then,
> you need to do this correctly (and no, I'm not going to tell you how to
> do that as I don't like it being done...)
> 
Greg,

To support SR-IOV, netvsc registers for all netdev events. For netdev events related to the
VF interface, we need to do some special processing. And so, we need to determine
if the device that is generating the netdev event is Hyper-V device or not
(passed through the PCI pass through driver). Is this justification sufficient.
As you have observed, currently there is no user of this API and that is because netvsc
will be the user. To avoid cross-tree dependency, we wanted to get this functionality in first
before submitting the netvsc patch.

Regards,

K. Y  

> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 02/15] hyperv: Add a function to detect hv_device kys@exchange.microsoft.com - 2016-12-01 16:40 +0100
  Re: [PATCH 02/15] hyperv: Add a function to detect hv_device Greg KH <gregkh@linuxfoundation.org> - 2016-12-01 21:40 +0100
    RE: [PATCH 02/15] hyperv: Add a function to detect hv_device KY Srinivasan <kys@microsoft.com> - 2016-12-02 06:50 +0100
  Re: [PATCH 02/15] hyperv: Add a function to detect hv_device Greg KH <gregkh@linuxfoundation.org> - 2016-12-01 21:40 +0100
  Re: [PATCH 02/15] hyperv: Add a function to detect hv_device Greg KH <gregkh@linuxfoundation.org> - 2016-12-01 21:50 +0100
    RE: [PATCH 02/15] hyperv: Add a function to detect hv_device KY Srinivasan <kys@microsoft.com> - 2016-12-02 07:10 +0100
      Re: [PATCH 02/15] hyperv: Add a function to detect hv_device Greg KH <gregkh@linuxfoundation.org> - 2016-12-02 07:50 +0100
        RE: [PATCH 02/15] hyperv: Add a function to detect hv_device KY Srinivasan <kys@microsoft.com> - 2016-12-02 08:20 +0100
          Re: [PATCH 02/15] hyperv: Add a function to detect hv_device Greg KH <gregkh@linuxfoundation.org> - 2016-12-02 08:40 +0100
            RE: [PATCH 02/15] hyperv: Add a function to detect hv_device KY Srinivasan <kys@microsoft.com> - 2016-12-02 16:50 +0100
              Re: [PATCH 02/15] hyperv: Add a function to detect hv_device Greg KH <gregkh@linuxfoundation.org> - 2016-12-02 17:10 +0100
                RE: [PATCH 02/15] hyperv: Add a function to detect hv_device KY Srinivasan <kys@microsoft.com> - 2016-12-02 22:50 +0100

csiph-web