Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534658

Re: [PATCH] powerpc: cputime: fix a compile warning

Show all headers | View raw

On Fri, Dec 2, 2016 at 3:15 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> yanjiang.jin@windriver.com writes:
>
>> diff --git a/arch/powerpc/include/asm/cputime.h b/arch/powerpc/include/asm/cputime.h
>> index 4f60db0..4423e97 100644
>> --- a/arch/powerpc/include/asm/cputime.h
>> +++ b/arch/powerpc/include/asm/cputime.h
>> @@ -228,7 +228,8 @@ static inline cputime_t clock_t_to_cputime(const unsigned long clk)
>>       return (__force cputime_t) ct;
>>  }
>>
>> -#define cputime64_to_clock_t(ct)     cputime_to_clock_t((cputime_t)(ct))
>> +#define cputime64_to_clock_t(ct)     \
>> +     (__force u64)(cputime_to_clock_t((cputime_t)(ct)))
>
> Given the name of the function is "cputime64 to clock_t", surely we
> should be returning a clock_t ?

Please fix it in cpuacct.c  Also check out git commit
527b0a76f41d062381adbb55c8eb61e32cb0bfc9
sched/cpuacct: Avoid %lld seq_printf warning

Balbir

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] powerpc: cputime: fix a compile warning Michael Ellerman <mpe@ellerman.id.au> - 2016-12-02 05:20 +0100
  Re: [PATCH] powerpc: cputime: fix a compile warning Balbir Singh <bsingharora@gmail.com> - 2016-12-02 05:30 +0100
    Re: [PATCH] powerpc: cputime: fix a compile warning yjin <yanjiang.jin@windriver.com> - 2016-12-02 05:40 +0100
      Re: [PATCH] powerpc: cputime: fix a compile warning Pan Xinhui <xinhui@linux.vnet.ibm.com> - 2016-12-02 06:20 +0100
        Re: [PATCH] powerpc: cputime: fix a compile warning yjin <yanjiang.jin@windriver.com> - 2016-12-02 06:20 +0100
  Re: [PATCH] powerpc: cputime: fix a compile warning Scott Wood <oss@buserror.net> - 2016-12-02 21:00 +0100

csiph-web