Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1534625
| From | zain wang <wzz@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions |
| Date | 2016-12-02 03:40 +0100 |
| Message-ID | <sJLVv-5Ru-17@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
We will ignored PSR setting if panel not support it. So, in this case, we should return from analogix_dp_enable/disable_psr() without any error code. Let's retrun 0 instead of -EINVAL when panel not support PSR in analogix_dp_enable/disable_psr(). Signed-off-by: zain wang <wzz@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 6e0447f..0cb3695 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -112,7 +112,7 @@ int analogix_dp_enable_psr(struct device *dev) struct edp_vsc_psr psr_vsc; if (!dp->psr_support) - return -EINVAL; + return 0; /* Prepare VSC packet as per EDP 1.4 spec, Table 6.9 */ memset(&psr_vsc, 0, sizeof(psr_vsc)); @@ -135,7 +135,7 @@ int analogix_dp_disable_psr(struct device *dev) struct edp_vsc_psr psr_vsc; if (!dp->psr_support) - return -EINVAL; + return 0; /* Prepare VSC packet as per EDP 1.4 spec, Table 6.9 */ memset(&psr_vsc, 0, sizeof(psr_vsc)); @@ -878,6 +878,8 @@ static void analogix_dp_commit(struct analogix_dp_device *dp) dp->psr_support = analogix_dp_detect_sink_psr(dp); if (dp->psr_support) analogix_dp_enable_sink_psr(dp); + else + dev_warn(dp->dev, "Sink not support PSR\n"); } /* -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions zain wang <wzz@rock-chips.com> - 2016-12-02 03:40 +0100
Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions Archit Taneja <architt@codeaurora.org> - 2016-12-02 05:00 +0100
Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions Sean Paul <seanpaul@chromium.org> - 2016-12-02 17:10 +0100
Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions Archit Taneja <architt@codeaurora.org> - 2016-12-05 04:20 +0100
Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions Sean Paul <seanpaul@chromium.org> - 2016-12-05 18:30 +0100
csiph-web