RE: [RFC PATCH] rtc/nxp: add FTM alarm driver as the wakeup source

From	Meng Yi <meng.yi@nxp.com>
Newsgroups	linux.kernel
Subject	RE: [RFC PATCH] rtc/nxp: add FTM alarm driver as the wakeup source
Date	2016-12-02 03:30 +0100
Message-ID	<sJLLP-5MM-1@gated-at.bofh.it> (permalink)
References	<sz2mZ-5I7-25@gated-at.bofh.it> <sz2mZ-5I7-23@gated-at.bofh.it> <sJnzP-4We-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > > +
> > > +static int nxp_ftm_rtc_read_time(struct device *dev, struct
> > > +rtc_time
> > > +*tm) {
> > > +	struct timeval time;
> > > +	unsigned long local_time;
> > > +
> > > +	do_gettimeofday(&time);
> > > +	local_time = (u32)(time.tv_sec - (sys_tz.tz_minuteswest * 60));
> > > +	rtc_time_to_tm(local_time, tm);
> > > +
> > > +	return 0;
> > > +}
> > > +
> >
> > This is not really getting time from the RTC since FTM is not a RTC
> > device, But we need to get the time to setup alarm, so we are using system
> time for now.
> > Anybody have better idea?
> >
> 
> No, that seems fine to me. I'll review the rest of the driver.

Thanks for your review, any feedback is welcomed!

> 
> 
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Meng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH] rtc/nxp: add FTM alarm driver as the wakeup source Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-12-01 01:40 +0100
  RE: [RFC PATCH] rtc/nxp: add FTM alarm driver as the wakeup source Meng Yi <meng.yi@nxp.com> - 2016-12-02 03:30 +0100

csiph-web