Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534560

Re: [PATCH v4 1/3] lib: add bitrev8x4()

Show all headers | View raw

Hello Anatolij,

Thanks for the review.

On 12/01/2016 02:45 PM, Anatolij Gustschin wrote:
> On Thu,  1 Dec 2016 09:04:50 -0800
> Joshua Clayton stillcompiling@gmail.com wrote:
> ...
>> diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h
>> index ec291c3..6d2e9ca 100644
>> --- a/arch/arm/include/asm/bitrev.h
>> +++ b/arch/arm/include/asm/bitrev.h
>> @@ -17,4 +17,9 @@ static __always_inline __attribute_const__ u8 __arch_bitrev8(u8 x)
>> 	return __arch_bitrev32((u32)x) >> 24;
>> }
>>
>> +static __always_inline __attribute_const__ u32 __arch_bitrev8x4(u32 x)
>> +{
>> +	__asm__ ("rbit %0, %1; rev %0, %0" : "=r" (x) : "r" (x));
> 	return x;
Oops thats a little embarrassing;
I'll add a return.
>> +}
> otherwise you get
>
> In function '__arch_bitrev8x4':
> warning: no return statement in function returning non-void [-Wreturn-type]
>
> --
> Anatolij

I wonder why I do not see this warning when compiling. The inlining, maybe?


Joshua

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 1/3] lib: add bitrev8x4() Joshua Clayton <stillcompiling@gmail.com> - 2016-12-01 18:10 +0100
  Re: [PATCH v4 1/3] lib: add bitrev8x4() Anatolij Gustschin <agust@denx.de> - 2016-12-01 23:50 +0100
    Re: [PATCH v4 1/3] lib: add bitrev8x4() Joshua Clayton <stillcompiling@gmail.com> - 2016-12-02 01:10 +0100
      Re: [PATCH v4 1/3] lib: add bitrev8x4() Anatolij Gustschin <agust@denx.de> - 2016-12-02 09:00 +0100

csiph-web