Re: [PATCH] mm: workingset: fix NULL ptr in count_shadow_nodes

From	Balbir Singh <bsingharora@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: workingset: fix NULL ptr in count_shadow_nodes
Date	2016-12-01 22:30 +0100
Message-ID	<sJH5w-2mT-19@gated-at.bofh.it> (permalink)
References	<sJzAZ-4ng-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 2, 2016 at 12:21 AM, Michal Hocko <mhocko@kernel.org> wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> 0a6b76dd23fa ("mm: workingset: make shadow node shrinker memcg aware")
> has made the workingset shadow nodes shrinker memcg aware. The
> implementation is not correct though because memcg_kmem_enabled() might
> become true while we are doing a global reclaim when the sc->memcg might
> be NULL which is exactly what Marek has seen:
>
<snip>
>
> -       if (memcg_kmem_enabled()) {
> +       if (sc->memcg) {
>                 pages = mem_cgroup_node_nr_lru_pages(sc->memcg, sc->nid,
>                                                      LRU_ALL_FILE);
>         } else {

Acked-by: Balbir Singh <bsingharora@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: workingset: fix NULL ptr in count_shadow_nodes Michal Hocko <mhocko@kernel.org> - 2016-12-01 14:30 +0100
  Re: [PATCH] mm: workingset: fix NULL ptr in count_shadow_nodes Vladimir Davydov <vdavydov@tarantool.org> - 2016-12-01 15:00 +0100
  Re: [PATCH] mm: workingset: fix NULL ptr in count_shadow_nodes Johannes Weiner <hannes@cmpxchg.org> - 2016-12-01 22:10 +0100
  Re: [PATCH] mm: workingset: fix NULL ptr in count_shadow_nodes Balbir Singh <bsingharora@gmail.com> - 2016-12-01 22:30 +0100

csiph-web