Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534370

Re: [PATCH v4] Fixes for compiling with clang

From Peter Foley <pefoley2@pefoley.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4] Fixes for compiling with clang
Date 2016-12-01 19:20 +0100
Message-ID <sJE7E-85V-41@gated-at.bofh.it> (permalink)
References <sHPTz-1JW-15@gated-at.bofh.it> <sInVg-724-13@gated-at.bofh.it> <sIRzY-1bf-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 29, 2016 at 6:22 AM, Michal Marek <mmarek@suse.com> wrote:
> Dne 28.11.2016 v 07:44 Peter Foley napsal(a):
> This adds new -Wno-* options also for the gcc case, is there a reason
> for this? Also, the -Wno-missing-field-initializers option is not
> available in some old gccs, so we would need a HOSTCC equivalent of
> cc-disable-warning.
>
> Michal

It appeared that the conditional was simply reversed, as
-fno-delete-null-pointer-checks is only supported by gcc, and
explicitly not supported by clang.
(see https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/Makefile?id=61163efae02040f66a95c8ed17f4407951ba58fa)
It could be that the fno-delete-null-pointer-checks option was simply
misplaced, and the Wno-options should still be guarded by if(clang),
would that be a better approach?

Thanks,

Peter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fixes for compiling with clang Peter Foley <pefoley2@pefoley.com> - 2016-11-26 05:40 +0100
  Re: [PATCH] Fixes for compiling with clang kbuild test robot <lkp@intel.com> - 2016-11-26 07:40 +0100
  [PATCH v2] Fixes for compiling with clang Peter Foley <pefoley2@pefoley.com> - 2016-11-26 19:10 +0100
    [PATCH v3] Fixes for compiling with clang Peter Foley <pefoley2@pefoley.com> - 2016-11-26 19:30 +0100
      [PATCH v4] Fixes for compiling with clang Peter Foley <pefoley2@pefoley.com> - 2016-11-28 07:50 +0100
        Re: [PATCH v4] Fixes for compiling with clang Michal Marek <mmarek@suse.com> - 2016-11-29 15:30 +0100
          Re: [PATCH v4] Fixes for compiling with clang Peter Foley <pefoley2@pefoley.com> - 2016-12-01 19:20 +0100
            Re: [PATCH v4] Fixes for compiling with clang Michal Marek <mmarek@suse.com> - 2016-12-02 13:40 +0100

csiph-web