Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic

From	Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic
Date	2016-12-01 17:20 +0100
Message-ID	<sJCfv-6mQ-5@gated-at.bofh.it> (permalink)
References	<sJAQp-56S-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Vitaly Kuznetsov <vkuznets@redhat.com> writes:

[snip]

>  static void __init ms_hyperv_init_platform(void)
>  {
>  	/*
> @@ -183,6 +204,9 @@ static void __init ms_hyperv_init_platform(void)
>  		pr_info("HyperV: LAPIC Timer Frequency: %#x\n",
>  			lapic_timer_frequency);
>  	}
> +
> +	register_nmi_handler(NMI_LOCAL, hv_nmi_unknown, NMI_FLAG_FIRST,
> +			     "hv_nmi_unknown");

This should probably be NMI_UNKNOWN instead of NMI_LOCAL. While it works
regardless and we don't have other NMIs on Hyper-V VMs (or do we?) I
think it would be better to do v3.

Sorry for the inconvenience.

-- 
  Vitaly

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-12-01 15:50 +0100
  Re: [PATCH v2] x86/hyperv: Handle unknown NMIs on one CPU when unknown_nmi_panic Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-12-01 17:20 +0100

csiph-web