Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1534252
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net v2] tipc: check minimum bearer MTU |
| Date | 2016-12-01 17:20 +0100 |
| Message-ID | <sJCfv-6mQ-17@gated-at.bofh.it> (permalink) |
| References | <sJxpw-35i-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, 2016-12-01 at 12:02 +0100, Michal Kubecek wrote:
[...]
> +/* check if device MTU is sufficient for tipc headers */
> +static inline bool tipc_check_mtu(struct net_device *dev, unsigned int reserve)
> +{
> + if (dev->mtu >= TIPC_MIN_BEARER_MTU + reserve)
> + return false;
> + netdev_warn(dev, "MTU too low for tipc bearer\n");
> + return true;
> +}
[...]
The comment says "check if ... sufficient" but the return value
indicates the opposite. Could you make these consistent?
Other than that, this looks OK to me. I haven't tested any version as
I don't know how to use TIPC.
Ben.
--
Ben Hutchings
A free society is one where it is safe to be unpopular. - Adlai
Stevenson
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net v2] tipc: check minimum bearer MTU Michal Kubecek <mkubecek@suse.cz> - 2016-12-01 12:10 +0100
Re: [PATCH net v2] tipc: check minimum bearer MTU Ben Hutchings <ben@decadent.org.uk> - 2016-12-01 17:20 +0100
Re: [PATCH net v2] tipc: check minimum bearer MTU Michal Kubecek <mkubecek@suse.cz> - 2016-12-01 19:00 +0100
csiph-web