Re: [PATCH] mtd: Allocate bdi objects dynamically

From	Marek Vasut <marek.vasut@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: Allocate bdi objects dynamically
Date	2016-12-01 17:00 +0100
Message-ID	<sJBWa-5Xk-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <s2rvs-1NC-5@gated-at.bofh.it> <sip6h-3Li-3@gated-at.bofh.it> <szoxb-3eu-21@gated-at.bofh.it> <sA3K2-4Yr-17@gated-at.bofh.it> <sILNU-5On-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/29/2016 09:12 AM, Sandeep Jain wrote:
> Dear Maintainers,
>    This patch is already reviewed twice with no issues.
> Requesting your attention for patch merge.
> 
> Thanks & Regards,
> Sandeep Jain
> 
> On Sat, Nov 05, 2016 at 08:22:31AM +0100, Marek Vasut wrote:
>> On 11/03/2016 12:34 PM, Sandeep Jain wrote:
>>> Dear Maintainers,
>>>   This patch is reviewed by Richard.
>>> Requesting for Maintainer's attention for patch merge.
>>>
>>> Thanks & Regards,
>>> Sandeep Jain
>>>
>>> On Sat, Sep 17, 2016 at 04:41:47PM +0200, Richard Weinberger wrote:
>>>> On Thu, Aug 4, 2016 at 4:01 PM, Sandeep Jain <Sandeep_Jain@mentor.com> wrote:
>>>>> From: Steve Longerbeam <steve_longerbeam@mentor.com>
>>>>>
>>>>> The MTD backing dev info objects mtd_bdi was statically allocated.
>>>>> So when MTD is built as a loadable module, this object fall in the
>>>>> vmalloc address space.
>>>>>
>>>>> The problem with that, is that the BDI APIs use wake_up_bit(), which calls
>>>>> virt_to_page() to retrieve the memory zone of the page containing the
>>>>> wait_queue to wake up, and virt_to_page() is not valid for vmalloc or
>>>>> highmem addresses.
>>>>>
>>>>> Fix this by allocating the BDI objects dynamically with kmalloc. The
>>>>> objects now fall in the logical address space so that BDI APIs will
>>>>> work in all cases (mtd builtin or module).
>>>>>
>>>>> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
>>>>> Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
>>>>> Signed-off-by: Sandeep Jain <Sandeep_Jain@mentor.com>
>>>>
>>>> Reviewed-by: Richard Weinberger <richard@nod.at>
>>
>> I don't see any obvious problem either:
>> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

Bump?

-- 
Best regards,
Marek Vasut

Thread

Re: [PATCH] mtd: Allocate bdi objects dynamically Sandeep Jain <Sandeep_Jain@mentor.com> - 2016-11-29 09:20 +0100
  Re: [PATCH] mtd: Allocate bdi objects dynamically Marek Vasut <marek.vasut@gmail.com> - 2016-12-01 17:00 +0100
    Re: [PATCH] mtd: Allocate bdi objects dynamically Marek Vasut <marek.vasut@gmail.com> - 2016-12-01 19:20 +0100
    Re: [PATCH] mtd: Allocate bdi objects dynamically Brian Norris <computersforpeace@gmail.com> - 2016-12-01 19:20 +0100

csiph-web