Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1534157

Re: [PATCH V5] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator()

Show all headers | View raw

On Thursday, December 01, 2016 05:55:48 AM Viresh Kumar wrote:
> On 30-11-16, 14:00, Stephen Boyd wrote:
> > On 11/30, Viresh Kumar wrote:
> > > From: Stephen Boyd <sboyd@codeaurora.org>
> > > 
> > > Joonyoung Shim reported an interesting problem on his ARM octa-core
> > > Odoroid-XU3 platform. During system suspend, dev_pm_opp_put_regulator()
> > > was failing for a struct device for which dev_pm_opp_set_regulator() is
> > > called earlier.
> > > 
> > > This happened because an earlier call to
> > > dev_pm_opp_of_cpumask_remove_table() function (from cpufreq-dt.c file)
> > > removed all the entries from opp_table->dev_list apart from the last CPU
> > > device in the cpumask of CPUs sharing the OPP.
> > > 
> > > But both dev_pm_opp_set_regulator() and dev_pm_opp_put_regulator()
> > > routines get CPU device for the first CPU in the cpumask. And so the OPP
> > > core failed to find the OPP table for the struct device.
> > > 
> > > This patch attempts to fix this problem by returning a pointer to the
> > > opp_table from dev_pm_opp_set_regulator() and using that as the
> > > parameter to dev_pm_opp_put_regulator(). This ensures that the
> > > dev_pm_opp_put_regulator() doesn't fail to find the opp table.
> > > 
> > > Note that similar design problem also exists with other
> > > dev_pm_opp_put_*() APIs, but those aren't used currently by anyone and
> > > so we don't need to update them for now.
> > > 
> > > [Viresh]: Written commit log and tested on exynos 5250.
> > > 
> > > Cc: # v4.4+ <stable@vger.kernel.org>
> > > Reported-by: Joonyoung Shim <jy0922.shim@samsung.com>
> > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > ---
> > 
> > You should have asked for my Signed-off-by instead of just adding
> > it.
> 
> I was worried about the 24 hrs that gets wasted because of 12 hrs
> difference in our time zones and so added you as the author and added
> your sob. :)
> 
> > Here it is to make things explicit and recorded:

Applied.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-30 05:10 +0100
  Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Joonyoung Shim <jy0922.shim@samsung.com> - 2016-11-30 07:20 +0100
    Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-30 09:10 +0100
      Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Joonyoung Shim <jy0922.shim@samsung.com> - 2016-12-01 02:50 +0100
        Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Viresh Kumar <viresh.kumar@linaro.org> - 2016-12-01 04:30 +0100
  Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-30 11:50 +0100
  [PATCH V5] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-30 12:00 +0100
    Re: [PATCH V5] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Stephen Boyd <sboyd@codeaurora.org> - 2016-11-30 23:10 +0100
      Re: [PATCH V5] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() Viresh Kumar <viresh.kumar@linaro.org> - 2016-12-01 01:30 +0100
        Re: [PATCH V5] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-12-01 15:40 +0100

csiph-web