Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1533163
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4.8 32/37] device-dax: fail all private mapping attempts |
| Date | 2016-11-30 11:00 +0100 |
| Message-ID | <sJ9Qe-4q9-39@gated-at.bofh.it> (permalink) |
| References | <sJ9wR-4iX-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
4.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dan Williams <dan.j.williams@intel.com>
commit 4cb19355ea19995941ccaad115dbfac6b75215ca upstream.
The device-dax implementation originally tried to be tricky and allow
private read-only mappings, but in the process allowed writable
MAP_PRIVATE + MAP_NORESERVE mappings. For simplicity and predictability
just fail all private mapping attempts since device-dax memory is
statically allocated and will never support overcommit.
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Fixes: dee410792419 ("/dev/dax, core: file operations and dax-mmap")
Reported-by: Pawel Lebioda <pawel.lebioda@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/dax/dax.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/dax/dax.c
+++ b/drivers/dax/dax.c
@@ -323,8 +323,8 @@ static int check_vma(struct dax_dev *dax
if (!dax_dev->alive)
return -ENXIO;
- /* prevent private / writable mappings from being established */
- if ((vma->vm_flags & (VM_NORESERVE|VM_SHARED|VM_WRITE)) == VM_WRITE) {
+ /* prevent private mappings from being established */
+ if ((vma->vm_flags & VM_SHARED) != VM_SHARED) {
dev_info(dev, "%s: %s: fail, attempted private mapping\n",
current->comm, func);
return -EINVAL;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4.8 00/37] 4.8.12-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-30 11:00 +0100
[PATCH 4.8 29/37] X.509: Fix double free in x509_cert_parse() [ver #3] Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-30 11:00 +0100
[PATCH 4.8 32/37] device-dax: fail all private mapping attempts Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-30 11:00 +0100
Re: [PATCH 4.8 14/37] drm/amdgpu: fix power state when port pm is unavailable Peter Wu <peter@lekensteyn.nl> - 2016-11-30 12:00 +0100
Re: [PATCH 4.8 14/37] drm/amdgpu: fix power state when port pm is unavailable Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-30 13:00 +0100
Re: [PATCH 4.8 14/37] drm/amdgpu: fix power state when port pm is unavailable Peter Wu <peter@lekensteyn.nl> - 2016-12-05 01:20 +0100
Re: [PATCH 4.8 14/37] drm/amdgpu: fix power state when port pm is unavailable Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-05 15:50 +0100
Re: [PATCH 4.8 00/37] 4.8.12-stable review Shuah Khan <shuah.kh@samsung.com> - 2016-11-30 17:10 +0100
Re: [PATCH 4.8 00/37] 4.8.12-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-01 08:20 +0100
Re: [PATCH 4.8 00/37] 4.8.12-stable review Guenter Roeck <linux@roeck-us.net> - 2016-12-01 02:00 +0100
Re: [PATCH 4.8 00/37] 4.8.12-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-01 08:20 +0100
Re: [PATCH 4.8 00/37] 4.8.12-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-12-01 08:20 +0100
csiph-web