Re: [PATCH 21/39] mtd: nand: denali: support 64bit capable DMA engine

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 21/39] mtd: nand: denali: support 64bit capable DMA engine
Date	2016-11-30 08:20 +0100
Message-ID	<sJ7lo-31Q-7@gated-at.bofh.it> (permalink)
References	<sHPAd-1yq-5@gated-at.bofh.it> <sHPAe-1yq-25@gated-at.bofh.it> <sIalk-6B5-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Boris,

2016-11-28 1:16 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
>
> If you follow my suggestions of definition function pointers, you'll
> just have to add a function pointer to the denali_caps struct:
>
>         void (*setup_dma)(struct denali_nand_info *denali, int op);
>


This is possible because both 32B and 64B variants have
the same function prototype.


However, I am not keen on doing so for ecc_handle(),
so, at this moment, I am not keen on doing so only for setup_dma() either.

If I see more cases that fit in callback handler approach,
I will think about switching to it with consistency.

-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 21/39] mtd: nand: denali: support 64bit capable DMA engine Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-26 19:10 +0100
  Re: [PATCH 21/39] mtd: nand: denali: support 64bit capable DMA  engine Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-27 17:20 +0100
    Re: [PATCH 21/39] mtd: nand: denali: support 64bit capable DMA  engine Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-30 08:20 +0100
    Re: [PATCH 21/39] mtd: nand: denali: support 64bit capable DMA engine Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-30 08:20 +0100

csiph-web