Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error messages

From	Eduardo Valentin <edubezval@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error messages
Date	2016-11-30 06:10 +0100
Message-ID	<sJ5jA-1Ed-5@gated-at.bofh.it> (permalink)
References	<sIs8y-1nY-5@gated-at.bofh.it> <sIs8y-1nY-17@gated-at.bofh.it> <sIFS9-1z0-7@gated-at.bofh.it> <sIJsJ-49m-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hey,

On Mon, Nov 28, 2016 at 09:47:29PM -0800, Brian Norris wrote:
> Hi,
> 

<cut>

> > > +		       __func__, table.mode);
> > 
> > Given that we are improving messages, would it be more informative to
> > say that you have an invalid table mode?
> 
> I considered the mode and ID listing to go hand in hand, so it was the
> whole table that is wrong. But it is just as well to say the "table
> mode" is wrong.
> 
> Maybe even better: "%s: unknown table mode: %d\n".
> 

Yup, that works for me, even better.

> And I guess same answer for patch 4, where you had the same question.

yes

> 
> Brian
> 
> > > +		return -EINVAL;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/5] thermal: rockchip: improve conversion error messages Caesar Wang <wxt@rock-chips.com> - 2016-11-28 12:20 +0100
  Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error  messages Eduardo Valentin <edubezval@gmail.com> - 2016-11-29 03:00 +0100
    Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error  messages Brian Norris <briannorris@chromium.org> - 2016-11-29 06:50 +0100
      Re: [PATCH v3 1/5] thermal: rockchip: improve conversion error  messages Eduardo Valentin <edubezval@gmail.com> - 2016-11-30 06:10 +0100

csiph-web