Re: [PATCH] misc: sram: remove useless #ifdef

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] misc: sram: remove useless #ifdef
Date	2016-11-30 00:40 +0100
Message-ID	<sJ0ae-6Ce-15@gated-at.bofh.it> (permalink)
References	<sGkoN-8oh-31@gated-at.bofh.it> <sIWzD-4hH-7@gated-at.bofh.it> <sIWJj-4l9-7@gated-at.bofh.it> <sIWT0-4En-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 29/11/2016 at 21:01:53 +0100, Greg Kroah-Hartman wrote :
> On Tue, Nov 29, 2016 at 08:54:00PM +0100, Alexandre Belloni wrote:
> > On 29/11/2016 at 20:41:54 +0100, Greg Kroah-Hartman wrote :
> > > On Tue, Nov 22, 2016 at 03:30:54PM +0100, Arnd Bergmann wrote:
> > > > A recent patch added a new function that is now unused whenever
> > > > CONFIG_OF is disabled:
> > > > 
> > > > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function]
> > > > 
> > > > There is actually no reason for the #ifdef, because the driver
> > > > currently cannot be used in a meaningful way without CONFIG_OF,
> > > > and there is no compile-time dependency.
> > > > 
> > > > Removing that #ifdef and the respective of_match_ptr() avoids the
> > > > warning and simplifies the driver slightly.
> > > > 
> > > > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support")
> > > 
> > > What tree is this commit in?  I can't seem to find it in one of mine, am
> > > I just missing it somewhere?
> > > 
> > 
> > It is in arm-soc (it went through the mach-at91 tree)
> 
> Ah, ok, nothing I can do about it then, nice!

Yeah, I was thinking Arnd would take it directly.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] misc: sram: remove useless #ifdef Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-29 20:50 +0100
  Re: [PATCH] misc: sram: remove useless #ifdef Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-11-29 21:00 +0100
    Re: [PATCH] misc: sram: remove useless #ifdef Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-29 21:10 +0100
      Re: [PATCH] misc: sram: remove useless #ifdef Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-11-30 00:40 +0100

csiph-web